Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machine #34

Merged
merged 26 commits into from
Jan 18, 2025
Merged

State machine #34

merged 26 commits into from
Jan 18, 2025

Conversation

avidraccoon
Copy link
Contributor

Adds a generic State Machine with ability for configuration to coppercore

@avidraccoon avidraccoon linked an issue Nov 11, 2024 that may be closed by this pull request
@jkleiber
Copy link
Member

@avidraccoon @aidnem I think I'm good with this change as long as we can do the following verification:

  1. Make high key's shooter subsystem work with this state machine
  2. Unit test this extensively

aidnem
aidnem previously approved these changes Dec 3, 2024
@aidnem aidnem dismissed their stale review December 3, 2024 00:26

I accidentally reviewed the wrong PR

@avidraccoon
Copy link
Contributor Author

@jkleiber is it fine if I implement the Intake subsystem instead?

@avidraccoon avidraccoon self-assigned this Dec 16, 2024
@jkleiber
Copy link
Member

@avidraccoon yeah that's fine. I'd like to get the state machine merged asap so if that's faster that works

@jkleiber
Copy link
Member

@avidraccoon can we prioritize getting this merged before the season starts on saturday?

@avidraccoon
Copy link
Contributor Author

Yes I have been working on getting it working whenever I have had time

@avidraccoon
Copy link
Contributor Author

Only problem is some things have been removed from the 2025 libraries

@avidraccoon
Copy link
Contributor Author

@jkleiber I'm having problem getting high key to work for 2025 is there some other way to verify.

@jkleiber
Copy link
Member

@avidraccoon if you make a simple example on 2025-Robot-Code that would also be fine

@avidraccoon avidraccoon requested a review from aidnem January 17, 2025 17:51
@avidraccoon
Copy link
Contributor Author

StateMachineVerification

@avidraccoon avidraccoon merged commit 7fc14dc into main Jan 18, 2025
6 checks passed
@jkleiber jkleiber deleted the StateMachine branch January 23, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State Machine
3 participants